linux-kernel - Re: [PATCH v2] net: macb: Clean 64b dma addresses if they are not detected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180925.103705.90948916724711521.davem@davemloft.net>
Date:   Tue, 25 Sep 2018 10:37:05 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     michal.simek@...inx.com
Cc:     linux-kernel@...r.kernel.org, monstr@...str.eu,
        edgar.iglesias@...inx.com, netdev@...r.kernel.org,
        nicolas.ferre@...rochip.com
Subject: Re: [PATCH v2] net: macb: Clean 64b dma addresses if they are not
 detected

From: Michal Simek <michal.simek@...inx.com>
Date: Tue, 25 Sep 2018 08:32:50 +0200

> Clear ADDR64 dma bit in DMACFG register in case that HW_DMA_CAP_64B is
> not detected on 64bit system.
> The issue was observed when bootloader(u-boot) does not check macb
> feature at DCFG6 register (DAW64_OFFSET) and enabling 64bit dma support
> by default. Then macb driver is reading DMACFG register back and only
> adding 64bit dma configuration but not cleaning it out.
> 
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> ---
> 
> Changes in v2:
> - Clean reg at the first place - Edgar
> - Update commit message

Applied, thank you.