linux-kernel - Re: [PATCH net] net: hns: fix for unmapping problem when SMMU is on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180925.104336.2276354373880447447.davem@davemloft.net>
Date:   Tue, 25 Sep 2018 10:43:36 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     salil.mehta@...wei.com
Cc:     yisen.zhuang@...wei.com, lipeng321@...wei.com,
        mehta.salil@...src.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com,
        linyunsheng@...wei.com
Subject: Re: [PATCH net] net: hns: fix for unmapping problem when SMMU is on

From: Salil Mehta <salil.mehta@...wei.com>
Date: Tue, 25 Sep 2018 10:21:55 +0100

> From: Yunsheng Lin <linyunsheng@...wei.com>
> 
> If SMMU is on, there is more likely that skb_shinfo(skb)->frags[i]
> can not send by a single BD. when this happen, the
> hns_nic_net_xmit_hw function map the whole data in a frags using
> skb_frag_dma_map, but unmap each BD' data individually when tx is
> done, which causes problem when SMMU is on.
> 
> This patch fixes this problem by ummapping the whole data in a
> frags when tx is done.
> 
> Signed-off-by: Yunsheng Lin <linyunsheng@...wei.com>
> Signed-off-by: Peng Li <lipeng321@...wei.com>
> Reviewed-by: Yisen Zhuang <yisen.zhuang@...wei.com>
> Signed-off-by: Salil Mehta <salil.mehta@...wei.com>

Applied, thank you.