linux-kernel - Re: [RFC PATCH 1/9] leds: add TI LMU backlight driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180926150145.GS5662@atomide.com>
Date:   Wed, 26 Sep 2018 08:01:45 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Dan Murphy <dmurphy@...com>
Cc:     robh+dt@...nel.org, jacek.anaszewski@...il.com, pavel@....cz,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        lee.jones@...aro.org, linux-omap@...r.kernel.org,
        linux-leds@...r.kernel.org, Milo Kim <milo.kim@...com>,
        Sebastian Reichel <sebastian.reichel@...labora.co.uk>
Subject: Re: [RFC PATCH 1/9] leds: add TI LMU backlight driver

* Dan Murphy <dmurphy@...com> [180926 13:14]:
> --- /dev/null
> +++ b/drivers/leds/ti-lmu-led-common.c
> +static int ti_lmu_common_enable(struct ti_lmu_bank *lmu_bank, bool enable)
> +{
> +	struct regmap *regmap = lmu_bank->regmap;
> +	unsigned long enable_time = lmu_bank->enable_usec;
> +	u8 reg = lmu_bank->enable_reg;
> +	u8 mask = BIT(lmu_bank->bank_id);
> +	u8 val = (enable == true) ? mask : 0;
> +	int ret;
> +
> +	return 0;

Hmm this early return probably needs to be left out on real hardawre?

> +	if (!reg)
> +		return -EINVAL;
> +
> +	ret = regmap_update_bits(regmap, reg, mask, val);
> +	if (ret)
> +		return ret;
> +
> +	if (enable_time > 0)
> +		usleep_range(enable_time, enable_time + 100);
> +
> +	return 0;
> +}

Regards,

Tony