linux-kernel - Re: [PATCH] EDAC, altera: work around int-to-pointer-cast warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Sep 2018 12:23:05 -0500
From:   Thor Thayer <thor.thayer@...ux.intel.com>
To:     Arnd Bergmann <arnd@...db.de>, Borislav Petkov <bp@...en8.de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     David Frey <dpfrey@...il.com>, Mark Rutland <mark.rutland@....com>,
        Ingo Molnar <mingo@...nel.org>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EDAC, altera: work around int-to-pointer-cast warnings

Hi Arnd,

On 09/27/2018 05:09 AM, Arnd Bergmann wrote:
> The altera edac driver passes a token from a DT resource as
> resource_size_t into an SMC call, but casts it to an __iomem pointer
> and then a plain void pointer inbetween, mixing three or four
> incompatible types in the process. The compiler complains about
> one of the conversions:
> 
> drivers/edac/altera_edac.c: In function 'altr_init_a10_ecc_block':
> drivers/edac/altera_edac.c:1053:10: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>     base = (void __iomem *)res.start;
>            ^
> drivers/edac/altera_edac.c: In function 'altr_edac_a10_probe':
> drivers/edac/altera_edac.c:2062:10: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>     base = (void __iomem *)res.start;
> 
> Using a static checker probably also notices the __iomem cast.  Solving
> this properly isn't trivial, but simply casting to a 'uintptr_t' instead
> of 'void __iomem *' makes it less wrong and should avoid the warnings.
> 
> Fixes: d5fc9125566c ("EDAC, altera: Combine Stratix10 and Arria10 probe functions")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/edac/altera_edac.c | 13 +++++++------
>   1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
> index 0e9e80789d99..c89d82aa2776 100644
> --- a/drivers/edac/altera_edac.c
> +++ b/drivers/edac/altera_edac.c
> @@ -1036,7 +1036,7 @@ altr_init_a10_ecc_block(struct device_node *np, u32 irq_mask,
>   	} else {
>   		struct device_node *sysmgr_np;
>   		struct resource res;
> -		void __iomem *base;
> +		uintptr_t base;
>   
>   		sysmgr_np = of_parse_phandle(np_eccmgr,
>   					     "altr,sysmgr-syscon", 0);
> @@ -1050,9 +1050,9 @@ altr_init_a10_ecc_block(struct device_node *np, u32 irq_mask,
>   			return -ENOMEM;
>   
>   		/* Need physical address for SMCC call */
> -		base = (void __iomem *)res.start;
> +		base = res.start;
>   
> -		ecc_mgr_map = regmap_init(NULL, NULL, base,
> +		ecc_mgr_map = regmap_init(NULL, NULL, (void *)base,
>   					  &s10_sdram_regmap_cfg);
>   	}
>   	of_node_put(np_eccmgr);
> @@ -2045,7 +2045,7 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
>   	} else {
>   		struct device_node *sysmgr_np;
>   		struct resource res;
> -		void __iomem *base;
> +		uintptr_t base;
>   
>   		sysmgr_np = of_parse_phandle(pdev->dev.of_node,
>   					     "altr,sysmgr-syscon", 0);
> @@ -2059,9 +2059,10 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
>   			return -ENOMEM;
>   
>   		/* Need physical address for SMCC call */
> -		base = (void __iomem *)res.start;
> +		base = res.start;
>   
> -		edac->ecc_mgr_map = devm_regmap_init(&pdev->dev, NULL, base,
> +		edac->ecc_mgr_map = devm_regmap_init(&pdev->dev, NULL,
> +						     (void *)base,
>   						     &s10_sdram_regmap_cfg);
>   	}
>   
Thanks for the fix.

Reviewed-by: Thor Thayer <thor.thayer@...ux.intel.com>