linux-kernel - Re: [RFC PATCH 7/9] leds: lm3633: Introduce the lm3633 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Sep 2018 23:47:52 +0200
From:   Pavel Machek <pavel@....cz>
To:     Dan Murphy <dmurphy@...com>
Cc:     robh+dt@...nel.org, jacek.anaszewski@...il.com,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        lee.jones@...aro.org, linux-omap@...r.kernel.org,
        linux-leds@...r.kernel.org
Subject: Re: [RFC PATCH 7/9] leds: lm3633: Introduce the lm3633 driver

Hi!

> > Duplicate.
> > 
> > Can we get some more sharing? One way would be to have struct with
> > all the constants (instead of #defines) use that...?
> 
> I will look at the adding common constants to but they should be common across
> more then just 2 devices.  As you can see the LM3632 code is quite different
> when you add in the flash/torch support.

LM3632 is indeed different, I see.

On the other hand, I'd really like to see the code shared, even if it
is just for 2 devices. (I believe that family is big enough that we'll
likely see more sharing in future).

Thanks,

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)