linux-kernel - Re: [RFC PATCH 7/9] leds: lm3633: Introduce the lm3633 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7fe653e5-a554-fe38-6183-217ebf474d48@ti.com>
Date:   Fri, 28 Sep 2018 11:48:28 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Pavel Machek <pavel@....cz>
CC:     <robh+dt@...nel.org>, <jacek.anaszewski@...il.com>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <lee.jones@...aro.org>, <linux-omap@...r.kernel.org>,
        <linux-leds@...r.kernel.org>
Subject: Re: [RFC PATCH 7/9] leds: lm3633: Introduce the lm3633 driver

Pavel

On 09/27/2018 04:47 PM, Pavel Machek wrote:
> Hi!
> 
>>> Duplicate.
>>>
>>> Can we get some more sharing? One way would be to have struct with
>>> all the constants (instead of #defines) use that...?
>>
>> I will look at the adding common constants to but they should be common across
>> more then just 2 devices.  As you can see the LM3632 code is quite different
>> when you add in the flash/torch support.
> 
> LM3632 is indeed different, I see.
> 
> On the other hand, I'd really like to see the code shared, even if it
> is just for 2 devices. (I believe that family is big enough that we'll
> likely see more sharing in future).
> 

Yes I have been looking at the other drivers I created that support 11 bit and
I plan to move them over to call the common code if the code is accepted.

I just finished debugging and getting the 3632 and 3633 drivers working with
flash/torch and configurable indicator support and there is a lot of code
diff especially around the node parsing and configuration.

Dan

> Thanks,
> 
> 									Pavel
> 


-- 
------------------
Dan Murphy