linux-kernel - Re: [PATCH v2 06/21] platform: goldfish: pipe: Add DMA support to goldfish pipe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180927051925.GA473@kroah.com>
Date:   Thu, 27 Sep 2018 07:19:25 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     rkir@...gle.com
Cc:     linux-kernel@...r.kernel.org, tkjos@...gle.com,
        Lingfeng Yang <lfy@...gle.com>
Subject: Re: [PATCH v2 06/21] platform: goldfish: pipe: Add DMA support to
 goldfish pipe

On Wed, Sep 26, 2018 at 04:02:19PM -0700, rkir@...gle.com wrote:
> From: Roman Kiryanov <rkir@...gle.com>
> 
> Goldfish DMA is an extension to the pipe device and is designed
> to facilitate high-speed RAM->RAM transfers from guest to host.
> 
> See uapi/linux/goldfish/goldfish_dma.h for more details.
> 
> Signed-off-by: Roman Kiryanov <rkir@...gle.com>
> Signed-off-by: Lingfeng Yang <lfy@...gle.com>
> ---
> Changes in v2:
>  - Got sign-off from Lingfeng Yang.
>  - Removed the license boilerplate from goldfish_dma.h.
>  - Rebased.

I don't understand this series.  Please start over with 01/XX as your
other patches were all merged.

And I still think you need a better justification for this, given the
many other ways the kernel already has for this feature...

thanks,

greg k-h