linux-kernel - RE: [PATCH v2] PM / devfreq: Stop the governor before device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180927052036epcms1p15fb2970f4ddc0256096d674d6932aabd@epcms1p1>
Date:   Thu, 27 Sep 2018 14:20:36 +0900
From:   MyungJoo Ham <myungjoo.ham@...sung.com>
To:     Kyungmin Park <kyungmin.park@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "john.reitan@....com" <john.reitan@....com>,
        "beata.michalska@....com" <beata.michalska@....com>,
        Vincent Donnefort <vincent.donnefort@....com>
Subject: RE: [PATCH v2] PM / devfreq: Stop the governor before
 device_unregister()

> From: Vincent Donnefort <vincent.donnefort@....com>
> 
> device_release() is freeing the resources before calling the device
> specific release callback which is, in the case of devfreq, stopping
> the governor.
> 
> It is a problem as some governors are using the device resources. e.g.
> simpleondemand which is using the devfreq deferrable monitoring work. If it
> is not stopped before the resources are freed, it might lead to a use after
> free.
> 
> Signed-off-by: Vincent Donnefort <vincent.donnefort@....com>
> Reviewed-by: John Einar Reitan <john.reitan@....com>
> Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>

Acked-by: MyungJoo Ham <myungjoo.ham@...sung.com>


Cheers,
MyungJoo