linux-kernel - Re: [PATCH v2] dt-bindings: input: pwm-vibrator: correct pwms in example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Sep 2018 08:45:39 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Brian Masney <masneyb@...tation.org>
Cc:     robh@...nel.org, dmitry.torokhov@...il.com,
        linux-input@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, mark.rutland@....com
Subject: Re: [PATCH v2] dt-bindings: input: pwm-vibrator: correct pwms in
 example

Hi,

On Wed, Sep 26, 2018 at 08:48:58PM -0400, Brian Masney wrote:
> In the example for the pwm-vibrator bindings, pwm8 is the direction pin,
> and pwm9 is the enable pin. The pwms on the vibrator node has these two
> values swapped so this patch corrects it.
> 
> Signed-off-by: Brian Masney <masneyb@...tation.org>
> ---
>
> Changes since v1:
> - Swapped the pwms values instead of the pwm-names values since enable
>   is required and direction is optional. Based on feedback from
>   Rob Herring.
> 
>  Documentation/devicetree/bindings/input/pwm-vibrator.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/input/pwm-vibrator.txt b/Documentation/devicetree/bindings/input/pwm-vibrator.txt
> index 09145d18491d..88c775a3fe21 100644
> --- a/Documentation/devicetree/bindings/input/pwm-vibrator.txt
> +++ b/Documentation/devicetree/bindings/input/pwm-vibrator.txt
> @@ -58,8 +58,8 @@ Example from Motorola Droid 4:
>  
>  	vibrator {
>  		compatible = "pwm-vibrator";
> -		pwms = <&pwm8 0 1000000000 0>,
> -		       <&pwm9 0 1000000000 0>;
> +		pwms = <&pwm9 0 1000000000 0>,
> +                       <&pwm8 0 1000000000 0>;
>  		pwm-names = "enable", "direction";
>  		direction-duty-cycle-ns = <1000000000>;
>  	};

Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.com>

 -- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)