linux-kernel - Re: [PATCH] drm/imx: fix build failure without CONFIG_DRM_FBDEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 27 Sep 2018 13:21:15 +0200
From:   Noralf Trønnes <noralf@...nnes.org>
To:     Arnd Bergmann <arnd@...db.de>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        David Airlie <airlied@...ux.ie>
Cc:     Lucas Stach <l.stach@...gutronix.de>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Sam Ravnborg <sam@...nborg.org>,
        Souptick Joarder <jrdr.linux@...il.com>,
        Leonard Crestez <leonard.crestez@....com>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/imx: fix build failure without
 CONFIG_DRM_FBDEV_EMULATION


Den 26.09.2018 21.38, skrev Arnd Bergmann:
> The variable is declared in an #ifdef section, but the user is
> now unconditional, which leads to a build failure:
>
> drivers/gpu/drm/imx/imx-drm-core.c: In function 'imx_drm_bind':
> drivers/gpu/drm/imx/imx-drm-core.c:264:6: error: 'legacyfb_depth' undeclared (first use in this function); did you mean 'lockdep_depth'?
>
> Remove the remaining #ifdef as well.
>
> Fixes: f53705fd9803 ("drm/imx: Use drm_fbdev_generic_setup()")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

Thanks for fixing my mistakes Arnd.
Applied to drm-misc-next.

Noralf.

>   drivers/gpu/drm/imx/imx-drm-core.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
> index a70f3131a377..0e6942f21a4e 100644
> --- a/drivers/gpu/drm/imx/imx-drm-core.c
> +++ b/drivers/gpu/drm/imx/imx-drm-core.c
> @@ -35,10 +35,8 @@
>   
>   #define MAX_CRTC	4
>   
> -#if IS_ENABLED(CONFIG_DRM_FBDEV_EMULATION)
>   static int legacyfb_depth = 16;
>   module_param(legacyfb_depth, int, 0444);
> -#endif
>   
>   DEFINE_DRM_GEM_CMA_FOPS(imx_drm_driver_fops);
>