linux-kernel - Re: [PATCH v2 6/7] drivers: oprofile: Avoids building driver from direct make command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADvQ+rFPiaGKLyzfSx4DmTnmgG15=Jk0RVy8xuYYyvLPJfDdkA@mail.gmail.com>
Date:   Thu, 27 Sep 2018 08:23:21 -0300
From:   Leonardo Bras <leobras.c@...il.com>
To:     Rolf Eike Beer <eike-kernel@...tec.de>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 6/7] drivers: oprofile: Avoids building driver from
 direct make command

Hello Rolf,

On Thu, Sep 27, 2018 at 3:34 AM, Rolf Eike Beer <eike-kernel@...tec.de> wrote:
> Am Donnerstag, 27. September 2018, 03:41:38 CEST schrieb Leonardo Brás:
>> Creates new Makefile to avoid building driver if
>> 'make drivers/oprofile/' is called directly.
>>
>> This driver is usually built from arch/$ARCH and seems to have
>> no meaning building alone.
>>
>> Signed-off-by: Leonardo Brás <leobras.c@...il.com>
>> ---
>>  drivers/oprofile/Makefile | 2 ++
>>  1 file changed, 2 insertions(+)
>>  create mode 100644 drivers/oprofile/Makefile
>>
>> diff --git a/drivers/oprofile/Makefile b/drivers/oprofile/Makefile
>> new file mode 100644
>> index 000000000000..acaed2ad6eee
>> --- /dev/null
>> +++ b/drivers/oprofile/Makefile
>> @@ -0,0 +1,2 @@
>> +#Does nothing, since the source is called from arch/$ARCH/ tree.
>> +
>
> Now there is a blank line where it does not need to be.
>
> Eike

Oh, it's a Makefile, and as all text files, it have to end with newline.
If I am wrong, please let me know.

Thanks for your feedback,

Leonardo Bras,