linux-kernel - Re: [PATCH v4] drm/panel: add Kingdisplay kd097d04 panel driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2158911.CuyhVEUmpb@phil>
Date:   Thu, 27 Sep 2018 14:51:37 +0200
From:   Heiko Stuebner <heiko@...ech.de>
To:     Thierry Reding <thierry.reding@...il.com>
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        seanpaul@...omium.org, briannorris@...omium.org, hl@...k-chips.com,
        nickey.yang@...k-chips.com, p.zabel@...gutronix.de
Subject: Re: [PATCH v4] drm/panel: add Kingdisplay kd097d04 panel driver

Hi Thierry,

Am Donnerstag, 27. September 2018, 14:07:21 CEST schrieb Thierry Reding:
> On Fri, Aug 17, 2018 at 11:37:31AM +0200, Heiko Stuebner wrote:
> > From: Nickey Yang <nickey.yang@...k-chips.com>
> > 
> > Support Kingdisplay kd097d04 9.7" 1536x2048 TFT LCD panel,
> > it is a MIPI dual-DSI panel.
> > 
> > v4:
> > - address Philipp's comments
> >   - real range for usleep_range and
> >   - poweroff ordering in kingdisplay_panel_prepare
> >   - return value beautification in panel_probe
> > - update author naming for full name
> > v3:
> > - address Thierry's comments
> >   - error handling for init dsi writes in init
> >   - unconditionally remove the panel
> >   - don't use drm_panel_detach
> >   - a bit of variable signednes wiggling
> > - I did talk to ChromeOS people and the delays really should be as short
> >   as possible, so dropped the 100ms from the delay comments
> > v2:
> > - update timing + cmds from chromeos kernel
> > - new backlight API including switch to devm_of_find_backlight
> > - fix most of Sean Paul's comments
> >   enable/prepare tracking seems something all panels do
> > - document origins of the init sequence
> > - lanes per dsi interface to 4 (two interfaces). Matches how tegra
> >   and pending rockchip dual-dsi handle (dual-)dsi lanes
> > - spdx header instead of license boilerplate
> > 
> > Signed-off-by: Nickey Yang <nickey.yang@...k-chips.com>
> > Signed-off-by: Heiko Stuebner <heiko@...ech.de>
> > ---
> >  drivers/gpu/drm/panel/Kconfig                 |  11 +
> >  drivers/gpu/drm/panel/Makefile                |   1 +
> >  .../drm/panel/panel-kingdisplay-kd097d04.c    | 473 ++++++++++++++++++
> >  3 files changed, 485 insertions(+)
> >  create mode 100644 drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c
> 
> This is missing device tree bindings.

nope it isn't ... as you already applied those from v3 [0]

Heiko

[0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/display/panel/kingdisplay,kd097d04.txt