linux-kernel - Re: [PATCH 1/2] dt-bindings: i2c-omap: Add new compatible for AM654 SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3943f2b1-3850-ad1e-6318-cfaec0eff485@ti.com>
Date:   Fri, 28 Sep 2018 10:57:18 +0530
From:   Vignesh R <vigneshr@...com>
To:     Peter Rosin <peda@...ntia.se>, Rob Herring <robh+dt@...nel.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>
CC:     "Nori, Sekhar" <nsekhar@...com>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Menon, Nishanth" <nm@...com>, "Kristo, Tero" <t-kristo@...com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 1/2] dt-bindings: i2c-omap: Add new compatible for AM654
 SoCs



On Wednesday 26 September 2018 08:14 PM, Peter Rosin wrote:
> On 2018-09-26 13:57, Vignesh R wrote:
>> AM654 SoCs have similar I2C IP as OMAP SoCs. Add new compatible to
>> handle AM654 SoCs.
>>
>> Signed-off-by: Vignesh R <vigneshr@...com>
>> ---
>>  Documentation/devicetree/bindings/i2c/i2c-omap.txt | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-omap.txt b/Documentation/devicetree/bindings/i2c/i2c-omap.txt
>> index 7e49839d4124..11ce869d682d 100644
>> --- a/Documentation/devicetree/bindings/i2c/i2c-omap.txt
>> +++ b/Documentation/devicetree/bindings/i2c/i2c-omap.txt
>> @@ -2,7 +2,8 @@ I2C for OMAP platforms
>>  
>>  Required properties :
>>  - compatible : Must be "ti,omap2420-i2c", "ti,omap2430-i2c", "ti,omap3-i2c"
>> -  or "ti,omap4-i2c"
>> +  or "ti,omap4-i2c" for OMAP2+ SoCs
>> +- compatible : Must "ti,am654-i2c", "ti,omap4-i2c" for AM654 SoCs
>                       ^
>                      be
> 
> Also, it looks bad with two 'compatible' entries in the properties list.
> I think the trend is to list one valid compatible (plus fallbacks)
> per line. So, you should consider reformatting, possibly like so:
> 
> - compatible : Must be one of
> 	"ti,omap2420-i2c"
> 	"ti,omap2430-i2c"
> 	"ti,omap3-i2c"
>         "ti,omap4-i2c"
> 	"ti,am654-i2c", "ti,omap4-i2c"
> 

I have sent v2 with these changes. Thanks for the review!


-- 
Regards
Vignesh