linux-kernel - Re: [PATCH v3] staging: ks7010: Add null pointer check for skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Sep 2018 11:13:25 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Aymen Qader <qader.aymen@...il.com>
Cc:     devel@...verdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, Wolfram Sang <wsa@...-dreams.de>
Subject: Re: [PATCH v3] staging: ks7010: Add null pointer check for skb

You might want to try running Smatch on your patches.  This is the
second one where maybe the results would have been interesting.

git clone http://repo.or.cz/w/smatch.git
cd smatch
make
cd ~/kernel/src/
~/smatch/smatch_scripts/kchecker drivers/staging/ks7010/ks_hostif.c

This patch introduced a problem, but the earlier one fixed a potential
problem in rtl8723bs:

drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:1274 OnAssocReq() error: uninitialized symbol 'ie_len'.

Unfortunately, Smatch missed the potential NULL dereference in
OnAssocReq()...  It wouldn't be that hard to fix...

regards,
dan carpenter