linux-kernel - Re: [PATCH v3] staging: ks7010: Add null pointer check for skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180928081601.is2gl764krxcvtlv@mwanda>
Date:   Fri, 28 Sep 2018 11:16:01 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Aymen Qader <qader.aymen@...il.com>
Cc:     devel@...verdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, Wolfram Sang <wsa@...-dreams.de>
Subject: Re: [PATCH v3] staging: ks7010: Add null pointer check for skb

Btw, if you have the cross function DB built then Smatch says that the
NULL check can be removed here no problem.

$ smdb hostif_data_request
[ snip ]
drivers/staging/ks7010/ks_wlan_net.c |   ks_wlan_start_xmit |  hostif_data_request |  PARAM_VALUE |  1 | skb | s64min-(-1),1-s64max

regards,
dan carpenter