linux-kernel - Re: [PATCH v3] staging: ks7010: Add null pointer check for skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180928082239.disbtllum3duvdcg@mwanda>
Date:   Fri, 28 Sep 2018 11:22:39 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Aymen Qader <qader.aymen@...il.com>
Cc:     Wolfram Sang <wsa@...-dreams.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] staging: ks7010: Add null pointer check for skb

On Thu, Sep 27, 2018 at 07:04:43PM +0100, Aymen Qader wrote:
> Retraction: in hindsight I see that with the current usage of this
> function, there is already a check for the socket buffer so this check
> is unnecessary. However, I'm not sure if it's considered good practice
> to keep this check anyway--in any case, ENOMEM isn't the right error
> to return.

When we find inconsistent NULL checks then we fix it to make sense.
Generally, we prefer a minimal style, with no extra code for future
proofing.  (The future seldom goes the way you expect and those extra
NULL checks would be easy to add back).

So, yes, do remove the NULL check but also fix the indenting while
you're at it.

Take your time to write patches.  I write them, then I sit on them over
night then I send them in the morning.  It means that sometimes other
people have already sent it but that's fine.  If you have to redo a
patch then don't send the v2 patch on the same day.  v2 patches are
stressful and you imagine that everyone is waiting for you to send it
or something.  We are not waiting for you.  We don't care if you wait
until next week to send these...

So when you write a v2 patch wait until the next day to send it.  Then
you will be calm when you review it.

regards,
dan carpenter