linux-kernel - Re: [PATCH] fat: Expand a slightly out-of-date comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sh1tewtw.fsf@mail.parknet.co.jp>
Date:   Fri, 28 Sep 2018 19:32:43 +0900
From:   OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:     Mihir Mehta <mihir@...utexas.edu>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fat: Expand a slightly out-of-date comment

Mihir Mehta <mihir@...utexas.edu> writes:

> The file namei.c seems to have been renamed to namei_msdos.c, so I
> decided to update the comment with the correct name, and expand it a bit
> to tell the reader what to look for.
> ---
>  fs/fat/dir.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
> index b833ffe..d954e18 100644
> --- a/fs/fat/dir.c
> +++ b/fs/fat/dir.c
> @@ -368,7 +368,8 @@ static int fat_parse_short(struct super_block *sb,
>  	}
>  
>  	memcpy(work, de->name, sizeof(work));
> -	/* see namei.c, msdos_format_name */
> +	/* For an explanation of the special treatment of 0x05 in
> +	   filenames, see msdos_format_name in namei_msdos.c */
>  	if (work[0] == 0x05)
>  		work[0] = 0xE5;

Sorry. However, could you use

	/*
         *
         */

style comment? Otherwise, looks good.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>