linux-kernel - Re: [PATCH] mfd: cros_ec: Avoid unneeded internal declaration warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Sep 2018 18:16:14 -0700
From:   Nathan Chancellor <natechancellor@...il.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-kernel@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>,
        Gwendal Grignou <gwendal@...omium.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Benson Leung <bleung@...omium.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [PATCH] mfd: cros_ec: Avoid unneeded internal declaration warning

On Wed, Sep 26, 2018 at 08:33:17PM -0700, Nathan Chancellor wrote:
> Clang warns:
> 
> drivers/mfd/cros_ec_dev.c:509:40: warning: variable 'cros_ec_id' is not
> needed and will not be emitted [-Wunneeded-internal-declaration]
> static const struct platform_device_id cros_ec_id[] = {
>                                        ^
> 1 warning generated.
> 
> Avoid this warning by adding it to the cros_ec_dev_driver definition
> under the id_table member like all other platform drivers.
> 
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---
> 
> I looked at several drivers with platform_device_id defintions and I
> didn't really find any where the definition wasn't then added to the
> platform_driver so I'm not sure if this was just missed in commit
> afbf8ec7c4f9 ("platform/chrome: cros_ec_dev - Add a platform
> device ID table") or if it was an intentional omission. I'm not super
> familiar with the inner workings of platform devices.
> 
> Should this commit be undesirable, the warning can be silenced with the
> __used attribute but this seemed like a more proper first commit.
> 
>  drivers/mfd/cros_ec_dev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> index 999dac752bcc..8f9d6964173e 100644
> --- a/drivers/mfd/cros_ec_dev.c
> +++ b/drivers/mfd/cros_ec_dev.c
> @@ -546,6 +546,7 @@ static struct platform_driver cros_ec_dev_driver = {
>  		.name = DRV_NAME,
>  		.pm = &cros_ec_dev_pm_ops,
>  	},
> +	.id_table = cros_ec_id,
>  	.probe = ec_device_probe,
>  	.remove = ec_device_remove,
>  	.shutdown = ec_device_shutdown,
> -- 
> 2.19.0
> 

It just occurred to me I probably should have added some of the Chromium
guys who have modified this driver to this patch. I've done that now.

Nathan