linux-kernel - Re: [PATCH] mfd: cros_ec: Avoid unneeded internal declaration warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181009100934.GK4939@dell>
Date:   Tue, 9 Oct 2018 11:09:34 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>,
        Gwendal Grignou <gwendal@...omium.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Benson Leung <bleung@...omium.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [PATCH] mfd: cros_ec: Avoid unneeded internal declaration warning

On Thu, 27 Sep 2018, Nathan Chancellor wrote:

> On Wed, Sep 26, 2018 at 08:33:17PM -0700, Nathan Chancellor wrote:
> > Clang warns:
> > 
> > drivers/mfd/cros_ec_dev.c:509:40: warning: variable 'cros_ec_id' is not
> > needed and will not be emitted [-Wunneeded-internal-declaration]
> > static const struct platform_device_id cros_ec_id[] = {
> >                                        ^
> > 1 warning generated.
> > 
> > Avoid this warning by adding it to the cros_ec_dev_driver definition
> > under the id_table member like all other platform drivers.
> > 
> > Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> > ---
> > 
> > I looked at several drivers with platform_device_id defintions and I
> > didn't really find any where the definition wasn't then added to the
> > platform_driver so I'm not sure if this was just missed in commit
> > afbf8ec7c4f9 ("platform/chrome: cros_ec_dev - Add a platform
> > device ID table") or if it was an intentional omission. I'm not super
> > familiar with the inner workings of platform devices.
> > 
> > Should this commit be undesirable, the warning can be silenced with the
> > __used attribute but this seemed like a more proper first commit.
> > 
> >  drivers/mfd/cros_ec_dev.c | 1 +
> >  1 file changed, 1 insertion(+)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog