linux-kernel - Re: [PATCH] mfd: cros_ec: Avoid unneeded internal declaration warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <153910175330.119890.2963290473787316949@swboyd.mtv.corp.google.com>
Date:   Tue, 09 Oct 2018 09:15:53 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Lee Jones <lee.jones@...aro.org>,
        Nathan Chancellor <natechancellor@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>,
        Gwendal Grignou <gwendal@...omium.org>,
        Benson Leung <bleung@...omium.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [PATCH] mfd: cros_ec: Avoid unneeded internal declaration warning

Quoting Nathan Chancellor (2018-09-27 18:16:14)
> On Wed, Sep 26, 2018 at 08:33:17PM -0700, Nathan Chancellor wrote:
> > diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> > index 999dac752bcc..8f9d6964173e 100644
> > --- a/drivers/mfd/cros_ec_dev.c
> > +++ b/drivers/mfd/cros_ec_dev.c
> > @@ -546,6 +546,7 @@ static struct platform_driver cros_ec_dev_driver = {
> >               .name = DRV_NAME,
> >               .pm = &cros_ec_dev_pm_ops,
> >       },
> > +     .id_table = cros_ec_id,
> >       .probe = ec_device_probe,
> >       .remove = ec_device_remove,
> >       .shutdown = ec_device_shutdown,
> > -- 
> > 2.19.0
> > 
> 
> It just occurred to me I probably should have added some of the Chromium
> guys who have modified this driver to this patch. I've done that now.

Looks OK to me.

Acked-by: Stephen Boyd <swboyd@...omium.org>