linux-kernel - Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180928122616.GA5249@centauri.lan>
Date:   Fri, 28 Sep 2018 14:26:16 +0200
From:   Niklas Cassel <niklas.cassel@...aro.org>
To:     Alex Elder <elder@...aro.org>
Cc:     andy.gross@...aro.org, david.brown@...aro.org,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS

On Fri, Sep 28, 2018 at 06:41:11AM -0500, Alex Elder wrote:
> Was there something wrong with this patch?  I sent it a long time
> ago but it still applies cleanly.  I can re-send if you like.

Hello Alex,

This patch does not apply on top of
https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/log/?h=for-next


When you don't specify a string for a Kconfig, then you won't be able to
select it via menuconfig, only through other Kconfigs, e.g.:
$ git grep QCOM_QMI_HELPERS
drivers/remoteproc/Kconfig:     select QCOM_QMI_HELPERS

What Kconfig is it that needs QCOM_QMI_HELPERS?
Why do you need to make is selectable via menuconfig?
Isn't it sufficient to add a "select QCOM_QMI_HELPERS" to that Kconfig?


Kind regards,
Niklas

> 
> 					-Alex
> 
> On 04/27/2018 09:03 AM, Alex Elder wrote:
> > Add a prompt to the "tristate" attribute in the Kconfig file in
> > which QCOM_QMI_HELPERS is defined; I find it doesn't get selected
> > without it.
> > 
> > Signed-off-by: Alex Elder <elder@...aro.org>
> > ---
> >  drivers/soc/qcom/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> > index 5c4535b545cc..81a501765cd9 100644
> > --- a/drivers/soc/qcom/Kconfig
> > +++ b/drivers/soc/qcom/Kconfig
> > @@ -36,7 +36,7 @@ config QCOM_PM
> >  	  low power modes.
> >  
> >  config QCOM_QMI_HELPERS
> > -	tristate
> > +	tristate "Qualcomm QMI Helpers"
> >  	depends on ARCH_QCOM && NET
> >  	help
> >  	  Helper library for handling QMI encoded messages.  QMI encoded
> > 
>