linux-kernel - Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4025f206-631a-55e9-9b7a-89dcf3370284@linaro.org>
Date:   Fri, 28 Sep 2018 08:23:03 -0500
From:   Alex Elder <elder@...aro.org>
To:     Niklas Cassel <niklas.cassel@...aro.org>
Cc:     andy.gross@...aro.org, david.brown@...aro.org,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS

On 09/28/2018 07:26 AM, Niklas Cassel wrote:
> On Fri, Sep 28, 2018 at 06:41:11AM -0500, Alex Elder wrote:
>> Was there something wrong with this patch?  I sent it a long time
>> ago but it still applies cleanly.  I can re-send if you like.
> 
> Hello Alex,
> 
> This patch does not apply on top of
> https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/log/?h=for-next

Sorry, I sent this before I tracked down where Andy's for-next
tree was.  It applied OK to linus/master.

> When you don't specify a string for a Kconfig, then you won't be able to
> select it via menuconfig, only through other Kconfigs, e.g.:
> $ git grep QCOM_QMI_HELPERS
> drivers/remoteproc/Kconfig:     select QCOM_QMI_HELPERS
> 
> What Kconfig is it that needs QCOM_QMI_HELPERS?

IPA, which is not yet merged.

The entry in "drivers/soc/qcom/Kconfig" for this option includes
help text, so I presume it was an oversight not to include a
string (prompt).  It is the only non-trivial entry in that file
that does not include one.  Why should this entry not be listed
in menus?

> Why do you need to make is selectable via menuconfig?
> Isn't it sufficient to add a "select QCOM_QMI_HELPERS" to that Kconfig?

I have CONFIG_IPA dependent on CONFIG_QCOM_QMI_HELPERS.  I could
change that to select it instead but I still think this entry
should be changed.

I'll mention that SLIM_QCOM_NGD_CTRL in drivers/slimbus/Kconfig
also depends on--rather than selects--QCOM_QMI_HELPERS.

					-Alex

> 
> Kind regards,
> Niklas
> 
>>
>> 					-Alex
>>
>> On 04/27/2018 09:03 AM, Alex Elder wrote:
>>> Add a prompt to the "tristate" attribute in the Kconfig file in
>>> which QCOM_QMI_HELPERS is defined; I find it doesn't get selected
>>> without it.
>>>
>>> Signed-off-by: Alex Elder <elder@...aro.org>
>>> ---
>>>  drivers/soc/qcom/Kconfig | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
>>> index 5c4535b545cc..81a501765cd9 100644
>>> --- a/drivers/soc/qcom/Kconfig
>>> +++ b/drivers/soc/qcom/Kconfig
>>> @@ -36,7 +36,7 @@ config QCOM_PM
>>>  	  low power modes.
>>>  
>>>  config QCOM_QMI_HELPERS
>>> -	tristate
>>> +	tristate "Qualcomm QMI Helpers"
>>>  	depends on ARCH_QCOM && NET
>>>  	help
>>>  	  Helper library for handling QMI encoded messages.  QMI encoded
>>>
>>