linux-kernel - Re: [PATCH] Bluetooth: hci_qca: Replace open-coded msleep()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <153815104962.119890.13155451003978822980@swboyd.mtv.corp.google.com>
Date:   Fri, 28 Sep 2018 09:10:49 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Johan Hedberg <johan.hedberg@...il.com>,
        Marcel Holtmann <marcel@...tmann.org>
Cc:     linux-kernel@...r.kernel.org, linux-bluetooth@...r.kernel.org,
        linux-arm-msm@...r.kernel.org,
        Thierry Escande <thierry.escande@...aro.org>
Subject: Re: [PATCH] Bluetooth: hci_qca: Replace open-coded msleep()

Quoting Stephen Boyd (2018-06-26 10:06:54)
> These three lines make up what msleep() already does, i.e. setting the
> task to uninterruptible, sleeping for so many jiffies, and then
> schedule() already puts the task state back to TASK_RUNNING when it
> returns. Make things clearer by just calling msleep() instead.
> 
> Cc: Thierry Escande <thierry.escande@...aro.org>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> ---

Marcel, can you pick this patch up?

>  drivers/bluetooth/hci_qca.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index 51790dd02afb..ef2b00bdf06d 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -908,9 +908,7 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate)
>          * controller will come back after they receive this HCI command
>          * then host can communicate with new baudrate to controller
>          */
> -       set_current_state(TASK_UNINTERRUPTIBLE);
> -       schedule_timeout(msecs_to_jiffies(BAUDRATE_SETTLE_TIMEOUT_MS));
> -       set_current_state(TASK_RUNNING);
> +       msleep(BAUDRATE_SETTLE_TIMEOUT_MS);
>  
>         return 0;
>  }