linux-kernel - Re: [PATCH] Bluetooth: hci_qca: Replace open-coded msleep()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <820F0357-DBD1-4278-8488-8C97A4107C19@holtmann.org>
Date:   Fri, 28 Sep 2018 19:20:03 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        linux-kernel@...r.kernel.org, linux-bluetooth@...r.kernel.org,
        linux-arm-msm@...r.kernel.org,
        Thierry Escande <thierry.escande@...aro.org>
Subject: Re: [PATCH] Bluetooth: hci_qca: Replace open-coded msleep()

Hi Stephen,

>> These three lines make up what msleep() already does, i.e. setting the
>> task to uninterruptible, sleeping for so many jiffies, and then
>> schedule() already puts the task state back to TASK_RUNNING when it
>> returns. Make things clearer by just calling msleep() instead.
>> 
>> Cc: Thierry Escande <thierry.escande@...aro.org>
>> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
>> ---
> 
> Marcel, can you pick this patch up?

I would do that, but unfortunately it does apply against bluetooth-next tree.

Regards

Marcel