linux-kernel - Re: [PATCH] firmware: Convert to using %pOFn instead of device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqJfWuL5NwXU_Ar76=MHgBeMPJqgDu9F8V+A=mC3Dor=9w@mail.gmail.com>
Date:   Fri, 28 Sep 2018 16:47:41 -0500
From:   Rob Herring <robh@...nel.org>
To:     Sudeep Holla <Sudeep.Holla@....com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] firmware: Convert to using %pOFn instead of device_node.name

On Mon, Aug 27, 2018 at 8:53 PM Rob Herring <robh@...nel.org> wrote:
>
> In preparation to remove the node name pointer from struct device_node,
> convert printf users to use the %pOFn format specifier.
>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>  drivers/firmware/scpi_pm_domain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Sudeep, looks like I missed Cc'ing you (or anyone) on this. Can you
please ack or apply this.

>
> diff --git a/drivers/firmware/scpi_pm_domain.c b/drivers/firmware/scpi_pm_domain.c
> index f395dec27113..390aa13391e4 100644
> --- a/drivers/firmware/scpi_pm_domain.c
> +++ b/drivers/firmware/scpi_pm_domain.c
> @@ -121,7 +121,7 @@ static int scpi_pm_domain_probe(struct platform_device *pdev)
>
>                 scpi_pd->domain = i;
>                 scpi_pd->ops = scpi_ops;
> -               sprintf(scpi_pd->name, "%s.%d", np->name, i);
> +               sprintf(scpi_pd->name, "%pOFn.%d", np, i);
>                 scpi_pd->genpd.name = scpi_pd->name;
>                 scpi_pd->genpd.power_off = scpi_pd_power_off;
>                 scpi_pd->genpd.power_on = scpi_pd_power_on;
> --
> 2.17.1
>