linux-kernel - Re: [PATCH v3] staging: mt7621-mmc: Remove #if 0 blocks and fix macros in sd.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180929031708.GA4120@nishad>
Date:   Sat, 29 Sep 2018 19:02:43 +0530
From:   Nishad Kamdar <nishadkamdar@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     NeilBrown <neil@...wn.name>, Joe Perches <joe@...ches.com>,
        devel@...verdev.osuosl.org,
        Christian Lütke-Stetzkamp <christian@...mp.de>,
        linux-kernel@...r.kernel.org, John Crispin <blogic@...nwrt.org>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH v3] staging: mt7621-mmc: Remove #if 0 blocks and fix
 macros in sd.c

On Fri, Sep 28, 2018 at 02:30:25PM +0200, Greg Kroah-Hartman wrote:
> On Thu, Sep 27, 2018 at 09:10:57PM +0530, Nishad Kamdar wrote:
> > This patch removes #if 0 code blocks and usages of the
> > functions defined in the #if 0 code block. It removes
> > the macro msdc_irq_restore() and replaces its usage
> > with call to the function called in the macro definition.
> > Issue found by checkpatch.
> 
> When you have to start listing all of the different things your patch
> does, that's a huge hint it needs to be broken up into smaller pieces.
> 
> Please make this a patch series, only doing on "logical" change at a
> time.  You are doing too many different things here all at once.
> 
> thanks
> 
> greg k-h

Ok I'll do that.

thanks for the review.

regards,
nishad