linux-kernel - Re: [PATCH v3] staging: mt7621-mmc: Remove #if 0 blocks and fix macros in sd.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Sep 2018 14:30:25 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Nishad Kamdar <nishadkamdar@...il.com>
Cc:     Joe Perches <joe@...ches.com>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, NeilBrown <neil@...wn.name>,
        Christian Lütke-Stetzkamp <christian@...mp.de>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        John Crispin <blogic@...nwrt.org>
Subject: Re: [PATCH v3] staging: mt7621-mmc: Remove #if 0 blocks and fix
 macros in sd.c

On Thu, Sep 27, 2018 at 09:10:57PM +0530, Nishad Kamdar wrote:
> This patch removes #if 0 code blocks and usages of the
> functions defined in the #if 0 code block. It removes
> the macro msdc_irq_restore() and replaces its usage
> with call to the function called in the macro definition.
> Issue found by checkpatch.

When you have to start listing all of the different things your patch
does, that's a huge hint it needs to be broken up into smaller pieces.

Please make this a patch series, only doing on "logical" change at a
time.  You are doing too many different things here all at once.

thanks

greg k-h