linux-kernel - Re: [PATCH V6 13/33] csky: Library functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180928162030.GE19827@infradead.org>
Date:   Fri, 28 Sep 2018 09:20:30 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Guo Ren <ren_guo@...ky.com>
Cc:     akpm@...ux-foundation.org, arnd@...db.de,
        daniel.lezcano@...aro.org, davem@...emloft.net,
        gregkh@...uxfoundation.org, jason@...edaemon.net,
        marc.zyngier@....com, mark.rutland@....com,
        mchehab+samsung@...nel.org, peterz@...radead.org, robh@...nel.org,
        robh+dt@...nel.org, tglx@...utronix.de,
        linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
        devicetree@...r.kernel.org, green.hu@...il.com,
        Chen Linfei <linfei_chen@...ky.com>,
        Mao Han <han_mao@...ky.com>
Subject: Re: [PATCH V6 13/33] csky: Library functions

> +unsigned long long notrace __bswapdi2(unsigned long long u)
> +{
> +	return (((u) & 0xff00000000000000ull) >> 56) |
> +	       (((u) & 0x00ff000000000000ull) >> 40) |
> +	       (((u) & 0x0000ff0000000000ull) >> 24) |
> +	       (((u) & 0x000000ff00000000ull) >>  8) |
> +	       (((u) & 0x00000000ff000000ull) <<  8) |
> +	       (((u) & 0x0000000000ff0000ull) << 24) |
> +	       (((u) & 0x000000000000ff00ull) << 40) |
> +	       (((u) & 0x00000000000000ffull) << 56);
> +}

How is this any better than using the generic byteswap helpers?

> +unsigned int notrace __bswapsi2(unsigned int u)
> +{
> +	return (((u) & 0xff000000) >> 24) |
> +	       (((u) & 0x00ff0000) >>  8) |
> +	       (((u) & 0x0000ff00) <<  8) |
> +	       (((u) & 0x000000ff) << 24);
> +}

Same here.