linux-kernel - Re: [PATCH V6 05/33] csky: System Call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180928161609.GD19827@infradead.org>
Date:   Fri, 28 Sep 2018 09:16:09 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Guo Ren <ren_guo@...ky.com>
Cc:     akpm@...ux-foundation.org, arnd@...db.de,
        daniel.lezcano@...aro.org, davem@...emloft.net,
        gregkh@...uxfoundation.org, jason@...edaemon.net,
        marc.zyngier@....com, mark.rutland@....com,
        mchehab+samsung@...nel.org, peterz@...radead.org, robh@...nel.org,
        robh+dt@...nel.org, tglx@...utronix.de,
        linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
        devicetree@...r.kernel.org, green.hu@...il.com
Subject: Re: [PATCH V6 05/33] csky: System Call

> +
> +static inline void
> +syscall_set_arguments(struct task_struct *task, struct pt_regs *regs,
> +		      unsigned int i, unsigned int n, const unsigned long *args)
> +{
> +	BUG_ON(i + n > 6);
> +        if (i == 0) {

Please fix your indentation - again checkpatch.pl will be helpful (even
if it sometimes is a littler overzealous).