linux-kernel - Re: [PATCH V6 04/33] csky: Exception handling and mm-fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180929170746.GF27796@guoren-Inspiron-7460>
Date:   Sun, 30 Sep 2018 01:07:46 +0800
From:   Guo Ren <ren_guo@...ky.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     akpm@...ux-foundation.org, arnd@...db.de,
        daniel.lezcano@...aro.org, davem@...emloft.net,
        gregkh@...uxfoundation.org, jason@...edaemon.net,
        marc.zyngier@....com, mark.rutland@....com,
        mchehab+samsung@...nel.org, peterz@...radead.org, robh@...nel.org,
        robh+dt@...nel.org, tglx@...utronix.de,
        linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
        devicetree@...r.kernel.org, green.hu@...il.com
Subject: Re: [PATCH V6 04/33] csky: Exception handling and mm-fault

On Fri, Sep 28, 2018 at 09:15:03AM -0700, Christoph Hellwig wrote:
> > +#ifndef CONFIG_CPU_HAS_TLBI
> > +	/*
> > +	 * We fault-in kernel-space virtual memory on-demand. The
> > +	 * 'reference' page table is init_mm.pgd.
> > +	 *
> > +	 * NOTE! We MUST NOT take any locks for this case. We may
> > +	 * be in an interrupt or a critical region, and should
> > +	 * only copy the information from the master page table,
> > +	 * nothing more.
> > +	 */
> > +	if (unlikely(address >= VMALLOC_START && address <= VMALLOC_END))
> > +	{
> 
> This doesn't fir the kernel style.  Please run checkpatch.pl over
> your code and fix at least all warnings that don't seem clearly bogus.
	if (unlikely(address >= VMALLOC_START) &&
	    unlikely(address <= VMALLOC_END)) {

Ok, use checkpatch.pl.

Best Regards
 Guo Ren