linux-kernel - Re: [PATCH V6 03/33] csky: Kernel booting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180929170909.GG27796@guoren-Inspiron-7460>
Date:   Sun, 30 Sep 2018 01:09:10 +0800
From:   Guo Ren <ren_guo@...ky.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     akpm@...ux-foundation.org, arnd@...db.de,
        daniel.lezcano@...aro.org, davem@...emloft.net,
        gregkh@...uxfoundation.org, jason@...edaemon.net,
        marc.zyngier@....com, mark.rutland@....com,
        mchehab+samsung@...nel.org, peterz@...radead.org, robh@...nel.org,
        robh+dt@...nel.org, tglx@...utronix.de,
        linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
        devicetree@...r.kernel.org, green.hu@...il.com
Subject: Re: [PATCH V6 03/33] csky: Kernel booting

On Fri, Sep 28, 2018 at 09:13:05AM -0700, Christoph Hellwig wrote:
> > +phys_addr_t __init_memblock memblock_end_of_REG0(void)
> > +{
> > +	return (memblock.memory.regions[0].base + memblock.memory.regions[0].size);
> > +}
> 
> No need for the braces.
Ok.

> > +	if (memblock.memory.cnt > 1) {
> > +		zone_size[ZONE_NORMAL]  = PFN_DOWN(memblock_start_of_REG1())
								- min_low_pfn;
> > +		zhole_size[ZONE_NORMAL] = PFN_DOWN(memblock_start_of_REG1())
								- max_low_pfn;
> 
> Please brake lines after 80 characters.
Ok.
> 
> > +	pr_info("C-SKY: https://github.com/c-sky/csky-linux\n");
> 
> I don't think this belongs into the kernel log.
Ok, remove it.

Best Regards
 Guo Ren