linux-kernel - Re: [PATCH net-next] net: caif: fix return type of ndo_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180929.113802.1016843680571572182.davem@davemloft.net>
Date:   Sat, 29 Sep 2018 11:38:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     dmitry.tarnyagin@...kless.no, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: caif: fix return type of ndo_start_xmit
 function

From: YueHaibing <yuehaibing@...wei.com>
Date: Wed, 26 Sep 2018 17:27:05 +0800

> @@ -1014,7 +1014,7 @@ static int cfhsi_xmit(struct sk_buff *skb, struct net_device *dev)
>  	int prio;
>  
>  	if (!dev)
> -		return -EINVAL;
> +		return NETDEV_TX_BUSY;
>  
>  	cfhsi = netdev_priv(dev);
>  

Even though the return type of ndo_start_xmit is netdev_tx_t, negative error codes are
still allowed I believe.

Look, reviewing these are pretty stressful for me, because you aren't documenting your
changes and in many cases the transformations look incorrect.

I'm tossing the rest of your changes in this area for now, sorry.

Please double check your work and resubmit this at some time in the not-too-near
future.

Thank you.