linux-kernel - Re: [PATCH net-next] net: caif: fix return type of ndo_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be1fc45d-3dca-3c41-a68a-e8d614bc4e6f@huawei.com>
Date:   Sun, 30 Sep 2018 09:52:55 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <dmitry.tarnyagin@...kless.no>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: caif: fix return type of ndo_start_xmit
 function


On 2018/9/30 2:38, David Miller wrote:
> From: YueHaibing <yuehaibing@...wei.com>
> Date: Wed, 26 Sep 2018 17:27:05 +0800
> 
>> @@ -1014,7 +1014,7 @@ static int cfhsi_xmit(struct sk_buff *skb, struct net_device *dev)
>>  	int prio;
>>  
>>  	if (!dev)
>> -		return -EINVAL;
>> +		return NETDEV_TX_BUSY;
>>  
>>  	cfhsi = netdev_priv(dev);
>>  
> 
> Even though the return type of ndo_start_xmit is netdev_tx_t, negative error codes are
> still allowed I believe.

I missed this and do the wrong thing.

> 
> Look, reviewing these are pretty stressful for me, because you aren't documenting your
> changes and in many cases the transformations look incorrect.
> 

I'm really sorry for this.

> I'm tossing the rest of your changes in this area for now, sorry.
> 
> Please double check your work and resubmit this at some time in the not-too-near
> future.
> 
> Thank you.
> 
> .
>