linux-kernel - RE: [PATCH] EDAC: Don't add devices under /sys/bus/edac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AT5PR8401MB037188B39CB70EB18ADAC11987E80@AT5PR8401MB0371.NAMPRD84.PROD.OUTLOOK.COM>
Date:   Tue, 2 Oct 2018 15:51:41 +0000
From:   "Ernst, Justin" <justin.ernst@....com>
To:     "Luck, Tony" <tony.luck@...el.com>
CC:     Borislav Petkov <bp@...en8.de>,
        Greg KH <gregkh@...uxfoundation.org>,
        "Anderson, Russ" <russ.anderson@....com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Aristeu Rozanski Filho <arozansk@...hat.com>
Subject: RE: [PATCH] EDAC: Don't add devices under /sys/bus/edac

The combined patches work on a 20 socket system. 
Thanks!
-Justin

> -----Original Message-----
> From: Mauro Carvalho Chehab [mailto:mchehab+samsung@...nel.org]
> Sent: Monday, October 1, 2018 8:23 PM
> To: Luck, Tony <tony.luck@...el.com>
> Cc: Borislav Petkov <bp@...en8.de>; Anderson, Russ
> <russ.anderson@....com>; Greg KH <gregkh@...uxfoundation.org>; Ernst,
> Justin <justin.ernst@....com>; Anderson, Russ <russ.anderson@....com>;
> Mauro Carvalho Chehab <mchehab@...nel.org>; linux-
> edac@...r.kernel.org; linux-kernel@...r.kernel.org; Aristeu Rozanski Filho
> <arozansk@...hat.com>
> Subject: Re: [PATCH] EDAC: Don't add devices under /sys/bus/edac
> 
> Em Mon, 1 Oct 2018 15:43:13 -0700
> "Luck, Tony" <tony.luck@...el.com> escreveu:
> 
> > Nobody(*) uses them.  Dropping this will allow us to make the total
> > number of memory controllers configurable (as we won't have to
> > worry about duplicated device names under this directory).
> >
> > (*) https://marc.info/?l=linux-edac&m=153809709903987&w=2
> >
> > Signed-off-by: Tony Luck <tony.luck@...el.com>
> > ---
> >
> > Boris: Apply this, then your earlier patch to get rid of the
> > hard coded limit on the number of memory controllers:
> >   https://marc.info/?l=linux-edac&m=153797567628947&w=2
> > the combination works on my 4 socket machine. Perhaps HPE
> > can test on their superdome.
> >
> 
> For both this and the referred patch:
> 
> Acked-by: Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
> 
> >  drivers/edac/edac_mc_sysfs.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c
> > index 20374b8248f0..4c1bee59c2e6 100644
> > --- a/drivers/edac/edac_mc_sysfs.c
> > +++ b/drivers/edac/edac_mc_sysfs.c
> > @@ -405,7 +405,6 @@ static int edac_create_csrow_object(struct
> mem_ctl_info *mci,
> >  				    struct csrow_info *csrow, int index)
> >  {
> >  	csrow->dev.type = &csrow_attr_type;
> > -	csrow->dev.bus = mci->bus;
> >  	csrow->dev.groups = csrow_dev_groups;
> >  	device_initialize(&csrow->dev);
> >  	csrow->dev.parent = &mci->dev;
> > @@ -636,7 +635,6 @@ static int edac_create_dimm_object(struct
> mem_ctl_info *mci,
> >  	dimm->mci = mci;
> >
> >  	dimm->dev.type = &dimm_attr_type;
> > -	dimm->dev.bus = mci->bus;
> >  	device_initialize(&dimm->dev);
> >
> >  	dimm->dev.parent = &mci->dev;
> > @@ -940,7 +938,6 @@ int edac_create_sysfs_mci_device(struct
> mem_ctl_info *mci,
> >  	device_initialize(&mci->dev);
> >
> >  	mci->dev.parent = mci_pdev;
> > -	mci->dev.bus = mci->bus;
> >  	mci->dev.groups = groups;
> >  	dev_set_name(&mci->dev, "mc%d", mci->mc_idx);
> >  	dev_set_drvdata(&mci->dev, mci);
> 
> 
> 
> Thanks,
> Mauro