linux-kernel - RE: [PATCH] driver core: device: add BUS_ATTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <HE1PR0401MB236354F325B7A56355068E35E0E80@HE1PR0401MB2363.eurprd04.prod.outlook.com>
Date:   Tue, 2 Oct 2018 09:43:35 +0000
From:   Ioana Ciornei <ioana.ciornei@....com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "idryomov@...il.com" <idryomov@...il.com>,
        "sage@...hat.com" <sage@...hat.com>,
        "elder@...nel.org" <elder@...nel.org>,
        "jth@...nel.org" <jth@...nel.org>,
        "benh@...nel.crashing.org" <benh@...nel.crashing.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "ceph-devel@...r.kernel.org" <ceph-devel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: RE: [PATCH] driver core: device: add BUS_ATTR_WO macro

> > Add BUS_ATTR_WO macro to make it easier to add attributes without
> > auditing the mode settings. Also, use the newly added macro where
> > appropriate.
> >
> > Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> > ---
> >  arch/powerpc/platforms/pseries/ibmebus.c | 12 ++++----
> >  drivers/block/rbd.c                      | 48 ++++++++++++++++----------------
> >  drivers/scsi/fcoe/fcoe_sysfs.c           |  4 +--
> >  drivers/scsi/fcoe/fcoe_transport.c       | 10 +++----
> >  include/linux/device.h                   |  2 ++
> >  include/scsi/libfcoe.h                   |  8 +++---
> >  6 files changed, 43 insertions(+), 41 deletions(-)
> 
> Nice!  This duplicates a lot of the work I did back in July but have not pushed out
> very far due to the other things that ended up happening around that time:
> 	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/log/?h=bus_cleanup 
> 
> As the patch series seen at that link shows, you can do this in more places than
> just what you did here.
> 
> Either way, you should break this up into the individual patches, like I did or you
> can take my patches if you want.  Getting the BUS_ATTR_WO() macro added is
> good to do now, and then you can go and hit up all of the different subsystems
> that should be converted over to it.

I can of course split my patch into individual ones and resubmit them, but as you already have the entire patch set ready, I feel like we can just push those. I looked through your changes and it seems like you covered all the subsystems. Please let me know if there is something else I should do.

My intention here was to first add the _WO attribute so that afterwards I can add a new bus attribute in the fsl-mc bus.

Ioana

> 
> thanks,
> 
> greg k-h