linux-kernel - Re: [PATCH] driver core: device: add BUS_ATTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 1 Oct 2018 14:08:04 -0700
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Ioana Ciornei <ioana.ciornei@....com>
Cc:     idryomov@...il.com, sage@...hat.com, elder@...nel.org,
        jth@...nel.org, benh@...nel.crashing.org,
        linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        ceph-devel@...r.kernel.org, linux-block@...r.kernel.org,
        linux-scsi@...r.kernel.org
Subject: Re: [PATCH] driver core: device: add BUS_ATTR_WO macro

On Mon, Oct 01, 2018 at 06:32:52PM +0300, Ioana Ciornei wrote:
> Add BUS_ATTR_WO macro to make it easier to add attributes without
> auditing the mode settings. Also, use the newly added macro where
> appropriate.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> ---
>  arch/powerpc/platforms/pseries/ibmebus.c | 12 ++++----
>  drivers/block/rbd.c                      | 48 ++++++++++++++++----------------
>  drivers/scsi/fcoe/fcoe_sysfs.c           |  4 +--
>  drivers/scsi/fcoe/fcoe_transport.c       | 10 +++----
>  include/linux/device.h                   |  2 ++
>  include/scsi/libfcoe.h                   |  8 +++---
>  6 files changed, 43 insertions(+), 41 deletions(-)

Nice!  This duplicates a lot of the work I did back in July but have not
pushed out very far due to the other things that ended up happening
around that time:
	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/log/?h=bus_cleanup

As the patch series seen at that link shows, you can do this in more
places than just what you did here.

Either way, you should break this up into the individual patches, like I
did or you can take my patches if you want.  Getting the BUS_ATTR_WO()
macro added is good to do now, and then you can go and hit up all of the
different subsystems that should be converted over to it.

thanks,

greg k-h