linux-kernel - Re: [PATCH v3 2/2] [media] imx214: Add imx214 camera sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181003104032.gesivjmiwf364ot3@paasikivi.fi.intel.com>
Date:   Wed, 3 Oct 2018 13:40:32 +0300
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
Cc:     Hans Verkuil <hans.verkuil@...co.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-media <linux-media@...r.kernel.org>, jacopo@...ndi.org
Subject: Re: [PATCH v3 2/2] [media] imx214: Add imx214 camera sensor driver

Hi Ricardo,

On Wed, Oct 03, 2018 at 09:17:56AM +0200, Ricardo Ribalda Delgado wrote:
> HI Sakari
> 
> Thanks a lot for your review!
> 
> On Tue, Oct 2, 2018 at 6:27 PM Sakari Ailus
> <sakari.ailus@...ux.intel.com> wrote:
> > > +static int imx214_s_power(struct v4l2_subdev *sd, int on)
> > > +{
> > > +     struct imx214 *imx214 = to_imx214(sd);
> > > +     int ret = 0;
> > > +
> > > +     on = !!on;
> > > +
> > > +     if (imx214->power_on == on)
> > > +             return 0;
> > > +
> > > +     if (on)
> > > +             ret = imx214_set_power_on(imx214);
> > > +     else
> > > +             imx214_set_power_off(imx214);
> > > +
> > > +     imx214->power_on = on;
> > > +
> > > +     return 0;
> >
> > Using runtime PM would relieve you of this function.
> 
> Tried using runtime PM, but did not manage to get it working with the
> qcom i2c driver. Will try again when this is merged on a separated
> patch.

Interesting. With runtime PM, also the parent device will be powered on
automatically. Usually that's what's needed after all.

Could you post the changes you made?

-- 
Sakari Ailus
sakari.ailus@...ux.intel.com