linux-kernel - Re: [PATCH] tools/pci: Fix compilation warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181003104121.GA13827@e107981-ln.cambridge.arm.com>
Date:   Wed, 3 Oct 2018 11:41:21 +0100
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Gustavo Pimentel <gustavo.pimentel@...opsys.com>
Cc:     bhelgaas@...gle.com, kishon@...com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/pci: Fix compilation warnings

On Thu, Aug 23, 2018 at 01:34:53PM +0200, Gustavo Pimentel wrote:
> Fix compilation warnings:
>  - remove unused variables
>  - change function return from int to void, since it's not used
> 
> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@...opsys.com>
> ---
>  tools/pci/pcitest.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)

Applied to pci/tools for v4.20, however, I reformatted the subject
to make it in line with previous commits and added the warnings that
you are fixing in the commit log.

Lorenzo

> diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
> index 9074b47..8ca1c62 100644
> --- a/tools/pci/pcitest.c
> +++ b/tools/pci/pcitest.c
> @@ -23,7 +23,6 @@
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <sys/ioctl.h>
> -#include <time.h>
>  #include <unistd.h>
>  
>  #include <linux/pcitest.h>
> @@ -43,17 +42,15 @@ struct pci_test {
>  	unsigned long	size;
>  };
>  
> -static int run_test(struct pci_test *test)
> +static void run_test(struct pci_test *test)
>  {
>  	long ret;
>  	int fd;
> -	struct timespec start, end;
> -	double time;
>  
>  	fd = open(test->device, O_RDWR);
>  	if (fd < 0) {
>  		perror("can't open PCI Endpoint Test device");
> -		return fd;
> +		return;
>  	}
>  
>  	if (test->barnum >= 0 && test->barnum <= 5) {
> -- 
> 2.7.4
>