linux-kernel - Re: [PATCH] ARM: dts: imx6sx-sdb: Fix enet phy regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Oct 2018 23:25:22 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Leonard Crestez <leonard.crestez@....com>
Cc:     Fabio Estevam <fabio.estevam@....com>,
        Fugang Duan <fugang.duan@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        NXP Linux Team <linux-imx@....com>,
        Sascha Hauer <kernel@...gutronix.de>
Subject: Re: [PATCH] ARM: dts: imx6sx-sdb: Fix enet phy regulator

Hi Leonard,

On Tue, Oct 2, 2018 at 3:42 PM Leonard Crestez <leonard.crestez@....com> wrote:

> @@ -371,10 +372,12 @@
>                                 MX6SX_PAD_RGMII1_RD1__ENET1_RX_DATA_1   0x3081
>                                 MX6SX_PAD_RGMII1_RD2__ENET1_RX_DATA_2   0x3081
>                                 MX6SX_PAD_RGMII1_RD3__ENET1_RX_DATA_3   0x3081
>                                 MX6SX_PAD_RGMII1_RX_CTL__ENET1_RX_EN    0x3081
>                                 MX6SX_PAD_ENET2_RX_CLK__ENET2_REF_CLK_25M       0x91
> +                               /* phy reset */
> +                               MX6SX_PAD_ENET2_CRS__GPIO2_IO_7         0x80000000

We should avoid using 0x80000000 as this relies on the bootloader
setting the IOMUX.

Please do like this insted:

MX6SX_PAD_ENET2_CRS__GPIO2_IO_7         0x10b0

Then you can add:

Reviewed-by: Fabio Estevam <festevam@...il.com>