linux-kernel - Re: [PATCH] ARM: dts: imx6sx-sdb: Fix enet phy regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <234ccbfccc26701bd0b9fd9cf2ffb5ad2414adec.camel@nxp.com>
Date:   Wed, 3 Oct 2018 11:49:32 +0000
From:   Leonard Crestez <leonard.crestez@....com>
To:     "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>
CC:     dl-linux-imx <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andy Duan <fugang.duan@....com>,
        Fabio Estevam <fabio.estevam@....com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: Re: [PATCH] ARM: dts: imx6sx-sdb: Fix enet phy regulator

On Tue, 2018-10-02 at 21:56 +0200, Linus Walleij wrote:
> On Tue, Oct 2, 2018 at 8:37 PM Leonard Crestez <
> leonard.crestez@....com> wrote:
> 
> > This issue was exposed by commit efdfeb079cc3 ("regulator: fixed:
> > Convert to use GPIO descriptor only") which causes the "gpios"
> > property
> > to also be parsed. Before that commit the "gpios" property had no
> > effect and PHY reset was only handled in the bootloader.
> 
> Wow that was a very interesting one.
> Turning over these stones sometimes expose the weirdest
> things.
> 
> This is one of the reasons why we need formal validation of
> DTS files: things look OK to the human eye and get merged
> but they are just syntactically wrong.
> 
> I guess I could hack to make "gpios" be ignored by the
> regulator GPIO quirks in gpiolib, but I take it you probably
> prefer to fix up the real issue like this.

Maybe you could document in fixed-regulator bindings that it now
supports the standard "gpios" property as well? There still seems to be
a restriction that the list must contain a single element.

Anyway, what my patch fixes is a board-specific issue which exists even
outside your patch: the enet phy regulator never worked as expected.

--
Regards,
Leonard