linux-kernel - Re: [PATCH] ARM: dts: imx6sx-sdb: Fix enet phy regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkda_Jhoiq12wtUA9s1hfsypfVztgmPQWCgmdOZE-Ct0CUg@mail.gmail.com>
Date:   Thu, 4 Oct 2018 11:02:10 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Leonard Crestez <leonard.crestez@....com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        NXP Linux Team <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andy Duan <fugang.duan@....com>,
        Fabio Estevam <fabio.estevam@....com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <kernel@...gutronix.de>
Subject: Re: [PATCH] ARM: dts: imx6sx-sdb: Fix enet phy regulator

On Wed, Oct 3, 2018 at 1:49 PM Leonard Crestez <leonard.crestez@....com> wrote:
> On Tue, 2018-10-02 at 21:56 +0200, Linus Walleij wrote:

> > I guess I could hack to make "gpios" be ignored by the
> > regulator GPIO quirks in gpiolib, but I take it you probably
> > prefer to fix up the real issue like this.
>
> Maybe you could document in fixed-regulator bindings that it now
> supports the standard "gpios" property as well? There still seems to be
> a restriction that the list must contain a single element.

OK you're right, fixing the docs to be more standards compliant
is indeed better.

> Anyway, what my patch fixes is a board-specific issue which exists even
> outside your patch: the enet phy regulator never worked as expected.

Indeed.

Yours,
Linus Walleij