linux-kernel - Re: [RFC PATCH v2 2/9] dt-bindings: ti-lmu: Remove LM3697

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fef2c612-ac35-126e-669e-335fb3075f64@ti.com>
Date:   Wed, 3 Oct 2018 07:24:23 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Pavel Machek <pavel@....cz>
CC:     <robh+dt@...nel.org>, <jacek.anaszewski@...il.com>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <lee.jones@...aro.org>, <linux-omap@...r.kernel.org>,
        <linux-leds@...r.kernel.org>
Subject: Re: [RFC PATCH v2 2/9] dt-bindings: ti-lmu: Remove LM3697

Hello

On 10/02/2018 02:28 AM, Pavel Machek wrote:
> On Fri 2018-09-28 13:29:47, Dan Murphy wrote:
>> Remove support for the LM3697 LED device
>> from the ti-lmu.  The LM3697 will be supported
>> via a stand alone LED driver.
>>
>> Signed-off-by: Dan Murphy <dmurphy@...com>
> 
> NAK, for reasons I explained before. Please add it to the patch so
> that it does not get applied by mistake. Ouch and AFAICT Rob was not
> happy with this either.
> 
> Yes, you are creating new drivers, ok; but that does _not_ mean you
> should create new binding.

I am copying my comment here on the review of this original binding for
records

I found the review or at least the reference for the ti-lmu.txt binding.

https://lore.kernel.org/patchwork/patch/764180/

Does not appear that the binding was sent to the device tree mail list.
(Maybe that email list did not exist in Feb 2017).

Especially with the amount of change that is being submitted in the
newer patchsets.

<new content>
Having found this submission and no comments on the review I would think
we need to take an exception on these bindings.

Dan


> 									Pavel
> 


-- 
------------------
Dan Murphy