linux-kernel - Re: [PATCH] perf/x86/intel: Add counter freezing quirk for Goldmont

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d5a49d4-85c8-0d7f-254e-d9d02419e718@linux.intel.com>
Date:   Wed, 3 Oct 2018 10:25:03 -0400
From:   "Liang, Kan" <kan.liang@...ux.intel.com>
To:     linux-kernel-owner@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>
Cc:     Peter Zijlstra <peterz@...radead.org>, mingo@...hat.com,
        acme@...nel.org, LKML <linux-kernel@...r.kernel.org>,
        eranian@...gle.com, ak@...ux.intel.com,
        alexander.shishkin@...ux.intel.com, x86@...nel.org
Subject: Re: [PATCH] perf/x86/intel: Add counter freezing quirk for Goldmont



On 10/3/2018 10:15 AM, linux-kernel-owner@...r.kernel.org wrote:
> To make it more generic, I think we also need to extend the struct 
> sku_microcode to check vendor and family.
> The "model" in struct x86_cpu_id is u16. I will also change "model" and 
> "stepping" to u16.
> 
> struct sku_microcode {
>      u16 vendor;
>      u16 family;
>      u16 model;
>      u16 stepping;
>      u32 microcode;
> };

No, should be consistent as struct cpuinfo_x86.
The struct sku_microcode should be

struct sku_microcode {
       u8 vendor;
       u8 family;
       u8 model;
       u8 stepping;
       u32 microcode;
};

Thanks,
Kan