[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20181004093644.GL19272@hirez.programming.kicks-ass.net>
Date: Thu, 4 Oct 2018 11:36:44 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>,
"Rafael J. Wysocki" <rjw@...ysocki.net>,
Linux PM <linux-pm@...r.kernel.org>,
Todd Kjos <tkjos@...gle.com>,
Joel Fernandes <joelaf@...gle.com>,
Colin Cross <ccross@...roid.com>,
Ramesh Thomas <ramesh.thomas@...el.com>,
Mel Gorman <mgorman@...e.de>, Ingo Molnar <mingo@...hat.com>,
Rafael Wysocki <rafael.j.wysocki@...el.com>,
Alex Shi <alex.shi@...aro.org>,
Philippe Ombredanne <pombredanne@...b.com>,
Thomas Gleixner <tglx@...utronix.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Kate Stewart <kstewart@...uxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] cpuidle/drivers/menu: Remove get_loadavg in the
performance multiplier
On Thu, Oct 04, 2018 at 10:47:04AM +0200, Rafael J. Wysocki wrote:
> > The comment is irrelevant as the remaining function is used for
> > statistics in addition to the perf multiplier. It does exactly what the
> > function name is.
>
> Which is my point. It shouldn't be dropped entirely, but updated IMO.
But the function name isn't the problem.. the problem that any use of
the number is fundamentally broken.
Powered by blists - more mailing lists