linux-kernel - Re: [PATCH 1/3] staging: rtl8188eu: fix line over 80 characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <539f9487-e973-87cb-5a97-b5874349f70e@gmail.com>
Date:   Thu, 4 Oct 2018 17:54:19 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     Joe Perches <joe@...ches.com>, gregkh@...uxfoundation.org
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] staging: rtl8188eu: fix line over 80 characters -
 style

Am 03.10.18 um 23:26 schrieb Joe Perches:
> On Wed, 2018-10-03 at 22:43 +0200, Michael Straube wrote:
>> Line break array declaration to clear a 'line over 80 characters'
>> checkpatch warning. For consistency replace 0x0 with 0x00.
> []
>> diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> []
>> @@ -39,7 +39,10 @@ extern unsigned char REALTEK_96B_IE[];
>>   /********************************************************
>>   MCS rate definitions
>>   *********************************************************/
>> -unsigned char	MCS_rate_1R[16] = {0xff, 0x00, 0x0, 0x0, 0x01, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0};
>> +unsigned char MCS_rate_1R[16] = {
>> +	0xff, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00,
>> +	0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
>> +};
> 
> Might as well make this const u8.
> 
> Here and as well the extern declarations in
> 	drivers/staging/rtl8188eu/core/rtw_mlme.c
> and
> 	drivers/staging/rtl8188eu/include/rtw_mlme.h
> 
> 

I'll send a patch with your suggestions.
Thanks.

Michael