linux-kernel - Re: [PATCH 2/3] staging: rtl8188eu: cleanup array declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2c8ffb7-4c62-8da9-9f78-00edb4edcb5e@gmail.com>
Date:   Thu, 4 Oct 2018 14:12:03 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     Joe Perches <joe@...ches.com>, gregkh@...uxfoundation.org
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] staging: rtl8188eu: cleanup array declaration - style

On 10/3/18 11:30 PM, Joe Perches wrote:
   
>>   static struct mlme_handler mlme_sta_tbl[] = {
> 
> Perhaps const here too, and as well, the struct
> declaration could use const char * instead of char *
> 

Making it const gives following warning.

drivers/staging/rtl8188eu/core/rtw_mlme_ext.c: In function 'mgt_dispatcher':
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4114:9: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   ptable = mlme_sta_tbl;
          ^

So I'll only change the char * to const char *.
Thanks.