linux-kernel - Re: [PATCH] scsi: iscsi_tcp: Explicitly cast param in iscsi_sw_tcp_host_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKwvOdk1M0t2WeB5AQjwzDy5Pb6HKV=kmh5kWrxNszFzaLjo7Q@mail.gmail.com>
Date:   Fri, 5 Oct 2018 14:20:47 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     lduncan@...e.com, cleech@...hat.com,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        open-iscsi@...glegroups.com, linux-scsi@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: iscsi_tcp: Explicitly cast param in iscsi_sw_tcp_host_get_param

On Wed, Oct 3, 2018 at 6:06 PM Nathan Chancellor
<natechancellor@...il.com> wrote:
>
> Clang warns when one enumerated type is implicitly converted to another.
>
> drivers/scsi/iscsi_tcp.c:803:15: warning: implicit conversion from
> enumeration type 'enum iscsi_host_param' to different enumeration type
> 'enum iscsi_param' [-Wenum-conversion]
>                                                  &addr, param, buf);
>                                                         ^~~~~
> 1 warning generated.
>
> iscsi_conn_get_addr_param handles ISCSI_HOST_PARAM_IPADDRESS just fine
> so add an explicit cast to iscsi_param to make it clear to Clang that
> this is expected behavior.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/153
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---
>  drivers/scsi/iscsi_tcp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
> index b025a0b74341..23354f206533 100644
> --- a/drivers/scsi/iscsi_tcp.c
> +++ b/drivers/scsi/iscsi_tcp.c
> @@ -800,7 +800,8 @@ static int iscsi_sw_tcp_host_get_param(struct Scsi_Host *shost,
>                         return rc;
>
>                 return iscsi_conn_get_addr_param((struct sockaddr_storage *)
> -                                                &addr, param, buf);
> +                                                &addr,
> +                                                (enum iscsi_param)param, buf);

Alternatively, you could also just pass ISCSI_HOST_PARAM_IPADDRESS in
place of the cast (since in this case param ==
ISCSI_HOST_PARAM_IPADDRESS), but I don't feel strongly about this
(maybe the maintainers do).
Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>

>         default:
>                 return iscsi_host_get_param(shost, param, buf);
>         }
> --
> 2.19.0
>


-- 
Thanks,
~Nick Desaulniers