linux-kernel - Re: [PATCH] mmc: meson-mx-sdio: mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1768f2bf-4253-e071-a93a-6ec2e19fc256@embeddedor.com>
Date:   Fri, 5 Oct 2018 23:20:07 +0200
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc:     ulf.hansson@...aro.org, carlo@...one.org, khilman@...libre.com,
        linux-amlogic@...ts.infradead.org, linux-mmc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] mmc: meson-mx-sdio: mark expected switch fall-through

Hi Martin,

On 10/5/18 11:10 PM, Martin Blumenstingl wrote:
> On Fri, Oct 5, 2018 at 12:15 PM Gustavo A. R. Silva
> <gustavo@...eddedor.com> wrote:
>>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Notice that in this particular case, I replaced the "fall-through:"
>> comment with a proper "fall through", which is what GCC is
>> expecting to find.
>>
>> Addresses-Coverity-ID: 1373880 ("Missing break in switch")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> Acked-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> 
> thank you for taking care of this!
> 

Glad to help. :)

Thanks
--
Gustavo