linux-kernel - Re: [PATCH v3 3/7] drivers: parisc: Avoids building driver if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.21.1810051332350.33@nippy.intranet>
Date:   Fri, 5 Oct 2018 14:10:04 +1000 (AEST)
From:   Finn Thain <fthain@...egraphics.com.au>
To:     Leonardo Bras <leobras.c@...il.com>
cc:     James Bottomley <James.Bottomley@...senpartnership.com>,
        lkcamp@...ts.libreplanetbr.org,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Robert Richter <rric@...nel.org>,
        "James E.J. Bottomley" <jejb@...isc-linux.org>,
        Helge Deller <deller@....de>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-m68k@...ts.linux-m68k.org, oprofile-list@...ts.sf.net,
        linux-parisc@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [PATCH v3 3/7] drivers: parisc: Avoids building driver if
 CONFIG_PARISC is disabled

On Thu, 4 Oct 2018, Leonardo Bras wrote:

> ... 
> But, why these chosen Makefiles, and not all of them?

I think that inconsistency is untenable. If nothing else, it means your 
changes will get broken by other people who also apply constraints 
inconsistently.

I think you need to consider what happens when you apply this regime 
tree-wide. Either that or explain why it would make sense to build e.g. 
drivers/s390 but not drivers/s390/net.

--