linux-kernel - Re: [PATCH] Input: uinput - add a schedule point in uinput_inject

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181005040900.GV2674@linux.ibm.com>
Date:   Thu, 4 Oct 2018 21:09:00 -0700
From:   "Paul E. McKenney" <paulmck@...ux.ibm.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     linux-input@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: uinput - add a schedule point in
 uinput_inject_events()

On Thu, Oct 04, 2018 at 05:54:32PM -0700, Dmitry Torokhov wrote:
> Large writes to uinput interface may cause rcu stalls. Let's add
> cond_resched() to the loop to avoid this.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Reviewed-by: Paul E. McKenney <paulmck@...ux.ibm.com>

> ---
>  drivers/input/misc/uinput.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c
> index eb14ddf69346..8ec483e8688b 100644
> --- a/drivers/input/misc/uinput.c
> +++ b/drivers/input/misc/uinput.c
> @@ -598,6 +598,7 @@ static ssize_t uinput_inject_events(struct uinput_device *udev,
>  
>  		input_event(udev->dev, ev.type, ev.code, ev.value);
>  		bytes += input_event_size();
> +		cond_resched();
>  	}
>  
>  	return bytes;
> -- 
> 2.19.0.605.g01d371f741-goog
> 
> 
> -- 
> Dmitry
>